can: mcp251xfd: fix infinite loop when xmit fails (Linux Linux)

CVE-2024-41088
MEDIUM 5.5

At a glance

Source
NVD
EPSS
EPSS 0.23 % · percentile 13 ()
State
PUBLISHED
Published
Updated
Assigner
Linux
NVD status
Modified

Description

In the Linux kernel, the following vulnerability has been resolved: can: mcp251xfd: fix infinite loop when xmit fails When the mcp251xfd_start_xmit() function fails, the driver stops processing messages, and the interrupt routine does not return, running indefinitely even after killing the running application. Error messages: [ 441.298819] mcp251xfd spi2.0 can0: ERROR in mcp251xfd_start_xmit: -16 [ 441.306498] mcp251xfd spi2.0 can0: Transmit Event FIFO buffer not empty. (seq=0x000017c7, tef_tail=0x000017cf, tef_head=0x000017d0, tx_head=0x000017d3). ... and repeat forever. The issue can be triggered when multiple devices share the same SPI interface. And there is concurrent access to the bus. The problem occurs because tx_ring->head increments even if mcp251xfd_start_xmit() fails. Consequently, the driver skips one TX package while still expecting a response in mcp251xfd_handle_tefif_one(). Resolve the issue by starting a workqueue to write the tx obj synchronously if err = -EBUSY. In case of another error, decrement tx_ring->head, remove skb from the echo stack, and drop the message. [mkl: use more imperative wording in patch description]

Weaknesses (CWE)

  • CWE-835 — Loop with Unreachable Exit Condition

References

Scores

VersionScoreVectorScored by
CVSS 3.1MEDIUM 5.5CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:HNVD · nvd@nist.gov (Primary)

European references

CERT-FR advisories

Affected configurations (NVD CPE)

Affected products

ProductVersions
Linux · Linuxaffected 55e5b97f003e85e66babb55f357627d52081a264 < f926c022ebaabf7963bebf89a97201d66978a025 ; affected 55e5b97f003e85e66babb55f357627d52081a264 < 3e72558c1711d524e3150103739ddd06650e291b ; affected 55e5b97f003e85e66babb55f357627d52081a264 < 6c6b4afa59c2fb4d1759235f866d8caed2aa4729 ; affected 55e5b97f003e85e66babb55f357627d52081a264 < d8fb63e46c884c898a38f061c2330f7729e75510
Linux · Linuxaffected 5.10 ; unaffected 0 < 5.10 ; unaffected 6.1.97 ≤ 6.1.* ; unaffected 6.6.37 ≤ 6.6.* ; unaffected 6.9.8 ≤ 6.9.* ; unaffected 6.10 ≤ *

Sources

SourceLicence
CVE List (CVEProject cvelistV5)CVE Program Terms of Use
EPSS (FIRST.org)FIRST — attribution requested
ENISA EUVDENISA — reproduction authorised, source acknowledged
CERT-FR (ANSSI)Licence Ouverte / Etalab 2.0
NVD (NIST) via fkie-cad/nvd-json-data-feedsPublic domain — this product uses data from the NVD API but is not endorsed or certified by the NVD