net/mlx5: Properly link new fs rules into the tree (Linux Linux)

CVE-2024-35960
CRITICAL 9.1

At a glance

Source
NVD
EPSS
EPSS 1.41 % · percentile 73 ()
State
PUBLISHED
Published
Updated
Assigner
Linux
NVD status
Modified

Description

In the Linux kernel, the following vulnerability has been resolved: net/mlx5: Properly link new fs rules into the tree Previously, add_rule_fg would only add newly created rules from the handle into the tree when they had a refcount of 1. On the other hand, create_flow_handle tries hard to find and reference already existing identical rules instead of creating new ones. These two behaviors can result in a situation where create_flow_handle 1) creates a new rule and references it, then 2) in a subsequent step during the same handle creation references it again, resulting in a rule with a refcount of 2 that is not linked into the tree, will have a NULL parent and root and will result in a crash when the flow group is deleted because del_sw_hw_rule, invoked on rule deletion, assumes node->parent is != NULL. This happened in the wild, due to another bug related to incorrect handling of duplicate pkt_reformat ids, which lead to the code in create_flow_handle incorrectly referencing a just-added rule in the same flow handle, resulting in the problem described above. Full details are at [1]. This patch changes add_rule_fg to add new rules without parents into the tree, properly initializing them and avoiding the crash. This makes it more consistent with how rules are added to an FTE in create_flow_handle.

Weaknesses (CWE)

  • CWE-476 — NULL Pointer Dereference

References

Scores

VersionScoreVectorScored by
CVSS 3.1CRITICAL 9.1CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:HCISA-ADP
CVSS 3.1CRITICAL 9.1CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:HNVD · 134c704f-9b21-4f2e-91b3-4a467353bcc0 (Secondary)

European references

CERT-FR advisories

Affected configurations (NVD CPE)

Affected products

ProductVersions
Linux · Linuxaffected 74491de937125d0c98c9b9c9208b4105717a3caa < de0139719cdda82806a47580ca0df06fc85e0bd2 ; affected 74491de937125d0c98c9b9c9208b4105717a3caa < 1263b0b26077b1183c3c45a0a2479573a351d423 ; affected 74491de937125d0c98c9b9c9208b4105717a3caa < 3d90ca9145f6b97b38d0c2b6b30f6ca6af9c1801 ; affected 74491de937125d0c98c9b9c9208b4105717a3caa < 7aaee12b804c5e0374e7b132b6ec2158ff33dd64 ; affected 74491de937125d0c98c9b9c9208b4105717a3caa < 2e8dc5cffc844dacfa79f056dea88002312f253f ; affected 74491de937125d0c98c9b9c9208b4105717a3caa < 5cf5337ef701830f173b4eec00a4f984adeb57a0
Linux · Linuxaffected 4.10 ; unaffected 0 < 4.10 ; unaffected 4.19.313 ≤ 4.19.* ; unaffected 5.4.275 ≤ 5.4.* ; unaffected 5.10.216 ≤ 5.10.* ; unaffected 5.15.156 ≤ 5.15.*

Sources

SourceLicence
CVE List (CVEProject cvelistV5)CVE Program Terms of Use
EPSS (FIRST.org)FIRST — attribution requested
ENISA EUVDENISA — reproduction authorised, source acknowledged
CERT-FR (ANSSI)Licence Ouverte / Etalab 2.0
NVD (NIST) via fkie-cad/nvd-json-data-feedsPublic domain — this product uses data from the NVD API but is not endorsed or certified by the NVD