tcp: properly terminate timers for kernel sockets (Linux Linux)

CVE-2024-35910
HIGH 7.8

At a glance

Source
NVD
EPSS
EPSS 0.26 % · percentile 18 ()
State
PUBLISHED
Published
Updated
Assigner
Linux
NVD status
Modified

Description

In the Linux kernel, the following vulnerability has been resolved: tcp: properly terminate timers for kernel sockets We had various syzbot reports about tcp timers firing after the corresponding netns has been dismantled. Fortunately Josef Bacik could trigger the issue more often, and could test a patch I wrote two years ago. When TCP sockets are closed, we call inet_csk_clear_xmit_timers() to 'stop' the timers. inet_csk_clear_xmit_timers() can be called from any context, including when socket lock is held. This is the reason it uses sk_stop_timer(), aka del_timer(). This means that ongoing timers might finish much later. For user sockets, this is fine because each running timer holds a reference on the socket, and the user socket holds a reference on the netns. For kernel sockets, we risk that the netns is freed before timer can complete, because kernel sockets do not hold reference on the netns. This patch adds inet_csk_clear_xmit_timers_sync() function that using sk_stop_timer_sync() to make sure all timers are terminated before the kernel socket is released. Modules using kernel sockets close them in their netns exit() handler. Also add sock_not_owned_by_me() helper to get LOCKDEP support : inet_csk_clear_xmit_timers_sync() must not be called while socket lock is held. It is very possible we can revert in the future commit 3a58f13a881e ("net: rds: acquire refcount on TCP sockets") which attempted to solve the issue in rds only. (net/smc/af_smc.c and net/mptcp/subflow.c have similar code) We probably can remove the check_net() tests from tcp_out_of_resources() and __tcp_close() in the future.

References

Scores

VersionScoreVectorScored by
CVSS 3.1HIGH 7.8CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:HLinux
CVSS 3.1MEDIUM 5.8CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:HCISA-ADP
CVSS 3.1HIGH 7.8CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:HNVD · 416baaa9-dc9f-4396-8d5f-8c081fb06d67 (Secondary)
CVSS 3.1MEDIUM 5.8CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:HNVD · nvd@nist.gov (Primary)
CVSS 3.1MEDIUM 5.8CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:HNVD · 134c704f-9b21-4f2e-91b3-4a467353bcc0 (Secondary)

European references

CERT-FR advisories

Affected configurations (NVD CPE)

Affected products

ProductVersions
Linux · Linuxaffected 26abe14379f8e2fa3fd1bcf97c9a7ad9364886fe < 93f0133b9d589cc6e865f254ad9be3e9d8133f50 ; affected 26abe14379f8e2fa3fd1bcf97c9a7ad9364886fe < 44e62f5d35678686734afd47c6a421ad30772e7f ; affected 26abe14379f8e2fa3fd1bcf97c9a7ad9364886fe < e3e27d2b446deb1f643758a0c4731f5c22492810 ; affected 26abe14379f8e2fa3fd1bcf97c9a7ad9364886fe < 2e43d8eba6edd1cf05a3a20fdd77688fa7ec16a4 ; affected 26abe14379f8e2fa3fd1bcf97c9a7ad9364886fe < 91b243de910a9ac8476d40238ab3dbfeedd5b7de ; affected 26abe14379f8e2fa3fd1bcf97c9a7ad9364886fe < c1ae4d1e76eacddaacb958b67cd942082f800c87
Linux · Linuxaffected 4.2 ; unaffected 0 < 4.2 ; unaffected 4.19.312 ≤ 4.19.* ; unaffected 5.4.274 ≤ 5.4.* ; unaffected 5.10.215 ≤ 5.10.* ; unaffected 5.15.154 ≤ 5.15.*

Sources

SourceLicence
CVE List (CVEProject cvelistV5)CVE Program Terms of Use
EPSS (FIRST.org)FIRST — attribution requested
ENISA EUVDENISA — reproduction authorised, source acknowledged
CERT-FR (ANSSI)Licence Ouverte / Etalab 2.0
NVD (NIST) via fkie-cad/nvd-json-data-feedsPublic domain — this product uses data from the NVD API but is not endorsed or certified by the NVD