spi: bcm-qspi: return error if neither hif_mspi nor mspi is available (Linux Linux)

CVE-2023-53658
MEDIUM 5.5

At a glance

Source
NVD
EPSS
EPSS 0.15 % · percentile 5 ()
State
PUBLISHED
Published
Updated
Assigner
Linux
NVD status
Analyzed

Description

In the Linux kernel, the following vulnerability has been resolved: spi: bcm-qspi: return error if neither hif_mspi nor mspi is available If neither a "hif_mspi" nor "mspi" resource is present, the driver will just early exit in probe but still return success. Apart from not doing anything meaningful, this would then also lead to a null pointer access on removal, as platform_get_drvdata() would return NULL, which it would then try to dereference when trying to unregister the spi master. Fix this by unconditionally calling devm_ioremap_resource(), as it can handle a NULL res and will then return a viable ERR_PTR() if we get one. The "return 0;" was previously a "goto qspi_resource_err;" where then ret was returned, but since ret was still initialized to 0 at this place this was a valid conversion in 63c5395bb7a9 ("spi: bcm-qspi: Fix use-after-free on unbind"). The issue was not introduced by this commit, only made more obvious.

Weaknesses (CWE)

  • CWE-476 — NULL Pointer Dereference

References

Scores

VersionScoreVectorScored by
CVSS 3.1MEDIUM 5.5CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:HNVD · nvd@nist.gov (Primary)

European references

CERT-FR advisories

Affected configurations (NVD CPE)

Affected products

ProductVersions
Linux · Linuxaffected fa236a7ef24048bafaeed13f68df35a819794758 < a91c34357afcfaa5307e254f22a8452550a07b34 ; affected fa236a7ef24048bafaeed13f68df35a819794758 < d20db3c58a7f9361e370a7850ceb60dbdf62eea3 ; affected fa236a7ef24048bafaeed13f68df35a819794758 < 398e6a015877d44327f754aeb48ff3354945c78c ; affected fa236a7ef24048bafaeed13f68df35a819794758 < 32b9c8f7892c19f7f5c9fed5fb410b9fd5990bb6 ; affected fa236a7ef24048bafaeed13f68df35a819794758 < 217b6ea8cf7b819477bca597a6ae2d43d38ba283 ; affected fa236a7ef24048bafaeed13f68df35a819794758 < d3dcdb43c872a3b967345144151a2c9bb9124c9b
Linux · Linuxaffected 4.9 ; unaffected 0 < 4.9 ; unaffected 4.14.322 ≤ 4.14.* ; unaffected 4.19.291 ≤ 4.19.* ; unaffected 5.4.251 ≤ 5.4.* ; unaffected 5.10.188 ≤ 5.10.*

Sources

SourceLicence
CVE List (CVEProject cvelistV5)CVE Program Terms of Use
EPSS (FIRST.org)FIRST — attribution requested
ENISA EUVDENISA — reproduction authorised, source acknowledged
CERT-FR (ANSSI)Licence Ouverte / Etalab 2.0
NVD (NIST) via fkie-cad/nvd-json-data-feedsPublic domain — this product uses data from the NVD API but is not endorsed or certified by the NVD