s390/lcs: Fix return type of lcs_start_xmit() (Linux Linux)

CVE-2022-50728
Not available

At a glance

Source
NVD
EPSS
EPSS 0.28 % · percentile 21 ()
State
PUBLISHED
Published
Updated
Assigner
Linux
NVD status
Deferred

Description

In the Linux kernel, the following vulnerability has been resolved: s390/lcs: Fix return type of lcs_start_xmit() With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. A proposed warning in clang aims to catch these at compile time, which reveals: drivers/s390/net/lcs.c:2090:21: error: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndo_start_xmit = lcs_start_xmit, ^~~~~~~~~~~~~~ drivers/s390/net/lcs.c:2097:21: error: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndo_start_xmit = lcs_start_xmit, ^~~~~~~~~~~~~~ ->ndo_start_xmit() in 'struct net_device_ops' expects a return type of 'netdev_tx_t', not 'int'. Adjust the return type of lcs_start_xmit() to match the prototype's to resolve the warning and potential CFI failure, should s390 select ARCH_SUPPORTS_CFI_CLANG in the future.

References

European references

CERT-FR advisories

Affected products

ProductVersions
Linux · Linuxaffected dc1f8bf68b311b1537cb65893430b6796118498a < 7b4da3fcd513b8e67823eb80da37aad99b3339c1 ; affected dc1f8bf68b311b1537cb65893430b6796118498a < d49cc2b705711fb8fb849e7c660929b2100360b7 ; affected dc1f8bf68b311b1537cb65893430b6796118498a < e684215d8a903752e2b0cc946517fb61e57a880a ; affected dc1f8bf68b311b1537cb65893430b6796118498a < 20022d551f2064a194d8e0acb6cd7a85094a17b2 ; affected dc1f8bf68b311b1537cb65893430b6796118498a < ebc3c77785dc8b5b626309c0032a38fbb139287a ; affected dc1f8bf68b311b1537cb65893430b6796118498a < 5ad774fb823c24bbeb21a15a67103ea7a6f5b928
Linux · Linuxaffected 2.6.32 ; unaffected 0 < 2.6.32 ; unaffected 4.9.337 ≤ 4.9.* ; unaffected 4.14.303 ≤ 4.14.* ; unaffected 4.19.270 ≤ 4.19.* ; unaffected 5.4.229 ≤ 5.4.*

Sources

SourceLicence
CVE List (CVEProject cvelistV5)CVE Program Terms of Use
EPSS (FIRST.org)FIRST — attribution requested
ENISA EUVDENISA — reproduction authorised, source acknowledged
CERT-FR (ANSSI)Licence Ouverte / Etalab 2.0
NVD (NIST) via fkie-cad/nvd-json-data-feedsPublic domain — this product uses data from the NVD API but is not endorsed or certified by the NVD