net: batman-adv: fix error handling (Linux Linux)
At a glance
- Source
- NVD
- EPSS
- EPSS 0.74 % · percentile 55 ()
- State
- PUBLISHED
- Published
- Updated
- Assigner
- Linux
- NVD status
- Analyzed
Description
In the Linux kernel, the following vulnerability has been resolved: net: batman-adv: fix error handling Syzbot reported ODEBUG warning in batadv_nc_mesh_free(). The problem was in wrong error handling in batadv_mesh_init(). Before this patch batadv_mesh_init() was calling batadv_mesh_free() in case of any batadv_*_init() calls failure. This approach may work well, when there is some kind of indicator, which can tell which parts of batadv are initialized; but there isn't any. All written above lead to cleaning up uninitialized fields. Even if we hide ODEBUG warning by initializing bat_priv->nc.work, syzbot was able to hit GPF in batadv_nc_purge_paths(), because hash pointer in still NULL. [1] To fix these bugs we can unwind batadv_*_init() calls one by one. It is good approach for 2 reasons: 1) It fixes bugs on error handling path 2) It improves the performance, since we won't call unneeded batadv_*_free() functions. So, this patch makes all batadv_*_init() clean up all allocated memory before returning with an error to no call correspoing batadv_*_free() and open-codes batadv_mesh_free() with proper order to avoid touching uninitialized fields.
Weaknesses (CWE)
- CWE-544 — Missing Standardized Error Handling Mechanism
References
- https://git.kernel.org/stable/c/0c6b199f09be489c48622537a550787fc80aea73
- https://git.kernel.org/stable/c/07533f1a673ce1126d0a72ef1e4b5eaaa3dd6d20
- https://git.kernel.org/stable/c/e50f957652190b5a88a8ebce7e5ab14ebd0d3f00
- https://git.kernel.org/stable/c/fbf150b16a3635634b7dfb7f229d8fcd643c6c51
- https://git.kernel.org/stable/c/6422e8471890273994fe8cc6d452b0dcd2c9483e
- https://git.kernel.org/stable/c/b0a2cd38553c77928ef1646ed1518486b1e70ae8
- https://git.kernel.org/stable/c/a8f7359259dd5923adc6129284fdad12fc5db347
- https://git.kernel.org/stable/c/6f68cd634856f8ca93bafd623ba5357e0f648c68
Scores
| Version | Score | Vector | Scored by |
|---|---|---|---|
| CVSS 3.1 | MEDIUM 5.3 | CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:H | CISA-ADP |
| CVSS 3.1 | MEDIUM 5.3 | CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:H | NVD · 134c704f-9b21-4f2e-91b3-4a467353bcc0 (Secondary) |
European references
- ENISA EUVD · EUVD-2021-34487
- GCVE · GCVE-0-2021-47482
CERT-FR advisories
- CERTFR-2024-AVI-0526 — Multiples vulnérabilités dans le noyau Linux de SUSE · cert.ssi.gouv.fr
- CERTFR-2024-AVI-0496 — Multiples vulnérabilités dans le noyau Linux de SUSE · cert.ssi.gouv.fr
Affected configurations (NVD CPE)
cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*≥ 2.6.38 < 4.4.293cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*≥ 4.5 < 4.9.289cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*≥ 4.10 < 4.14.254cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*≥ 4.15 < 4.19.215cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*≥ 4.20 < 5.4.157cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*≥ 5.5 < 5.10.77cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*≥ 5.11 < 5.14.16cpe:2.3:o:linux:linux_kernel:5.15:rc1:*:*:*:*:*:*cpe:2.3:o:linux:linux_kernel:5.15:rc2:*:*:*:*:*:*cpe:2.3:o:linux:linux_kernel:5.15:rc3:*:*:*:*:*:*cpe:2.3:o:linux:linux_kernel:5.15:rc4:*:*:*:*:*:*cpe:2.3:o:linux:linux_kernel:5.15:rc5:*:*:*:*:*:*cpe:2.3:o:linux:linux_kernel:5.15:rc6:*:*:*:*:*:*cpe:2.3:o:linux:linux_kernel:5.15:rc7:*:*:*:*:*:*
Affected products
| Product | Versions |
|---|---|
| Linux · Linux | affected c6c8fea29769d998d94fcec9b9f14d4b52b349d3 < 0c6b199f09be489c48622537a550787fc80aea73 ; affected c6c8fea29769d998d94fcec9b9f14d4b52b349d3 < 07533f1a673ce1126d0a72ef1e4b5eaaa3dd6d20 ; affected c6c8fea29769d998d94fcec9b9f14d4b52b349d3 < e50f957652190b5a88a8ebce7e5ab14ebd0d3f00 ; affected c6c8fea29769d998d94fcec9b9f14d4b52b349d3 < fbf150b16a3635634b7dfb7f229d8fcd643c6c51 ; affected c6c8fea29769d998d94fcec9b9f14d4b52b349d3 < 6422e8471890273994fe8cc6d452b0dcd2c9483e ; affected c6c8fea29769d998d94fcec9b9f14d4b52b349d3 < b0a2cd38553c77928ef1646ed1518486b1e70ae8 |
| Linux · Linux | affected 2.6.38 ; unaffected 0 < 2.6.38 ; unaffected 4.4.293 ≤ 4.4.* ; unaffected 4.9.289 ≤ 4.9.* ; unaffected 4.14.254 ≤ 4.14.* ; unaffected 4.19.215 ≤ 4.19.* |
Sources
| Source | Licence |
|---|---|
| CVE List (CVEProject cvelistV5) | CVE Program Terms of Use |
| EPSS (FIRST.org) | FIRST — attribution requested |
| ENISA EUVD | ENISA — reproduction authorised, source acknowledged |
| CERT-FR (ANSSI) | Licence Ouverte / Etalab 2.0 |
| NVD (NIST) via fkie-cad/nvd-json-data-feeds | Public domain — this product uses data from the NVD API but is not endorsed or certified by the NVD |