userfaultfd: release page in error path to avoid BUG_ON (Linux Linux)

CVE-2021-46988
MEDIUM 5.5

At a glance

Source
NVD
EPSS
EPSS 0.24 % · percentile 15 ()
State
PUBLISHED
Published
Updated
Assigner
Linux
NVD status
Analyzed

Description

In the Linux kernel, the following vulnerability has been resolved: userfaultfd: release page in error path to avoid BUG_ON Consider the following sequence of events: 1. Userspace issues a UFFD ioctl, which ends up calling into shmem_mfill_atomic_pte(). We successfully account the blocks, we shmem_alloc_page(), but then the copy_from_user() fails. We return -ENOENT. We don't release the page we allocated. 2. Our caller detects this error code, tries the copy_from_user() after dropping the mmap_lock, and retries, calling back into shmem_mfill_atomic_pte(). 3. Meanwhile, let's say another process filled up the tmpfs being used. 4. So shmem_mfill_atomic_pte() fails to account blocks this time, and immediately returns - without releasing the page. This triggers a BUG_ON in our caller, which asserts that the page should always be consumed, unless -ENOENT is returned. To fix this, detect if we have such a "dangling" page when accounting fails, and if so, release it before returning.

Weaknesses (CWE)

References

Scores

VersionScoreVectorScored by
CVSS 3.1MEDIUM 5.5CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:HNVD · nvd@nist.gov (Primary)

European references

CERT-FR advisories

Affected configurations (NVD CPE)

Affected products

ProductVersions
Linux · Linuxaffected cb658a453b9327ce96ce5222c24d162b5b65b564 < 319116227e52d49eee671f0aa278bac89b3c1b69 ; affected cb658a453b9327ce96ce5222c24d162b5b65b564 < 07c9b834c97d0fa3402fb7f3f3b32df370a6ff1f ; affected cb658a453b9327ce96ce5222c24d162b5b65b564 < b3f1731c6d7fbc1ebe3ed8eff6d6bec56d76ff43 ; affected cb658a453b9327ce96ce5222c24d162b5b65b564 < 140cfd9980124aecb6c03ef2e69c72d0548744de ; affected cb658a453b9327ce96ce5222c24d162b5b65b564 < ad53127973034c63b5348715a1043d0e80ceb330 ; affected cb658a453b9327ce96ce5222c24d162b5b65b564 < 2d59a0ed8b26b8f3638d8afc31f839e27759f1f6
Linux · Linuxaffected 4.11 ; unaffected 0 < 4.11 ; unaffected 4.14.233 ≤ 4.14.* ; unaffected 4.19.191 ≤ 4.19.* ; unaffected 5.4.120 ≤ 5.4.* ; unaffected 5.10.38 ≤ 5.10.*

Sources

SourceLicence
CVE List (CVEProject cvelistV5)CVE Program Terms of Use
EPSS (FIRST.org)FIRST — attribution requested
ENISA EUVDENISA — reproduction authorised, source acknowledged
CERT-FR (ANSSI)Licence Ouverte / Etalab 2.0
NVD (NIST) via fkie-cad/nvd-json-data-feedsPublic domain — this product uses data from the NVD API but is not endorsed or certified by the NVD